This repository was archived by the owner on Jan 6, 2025. It is now read-only.
LSPS1: Update message format and get client working #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-07-update-lsps1
branch
3 times, most recently
from
af8a822 to
e8a06f8
Compare
tnull
changed the title
tnull
force-pushed
the
2024-07-update-lsps1
branch
from
0e647a5 to
5210925
Compare
tnull
force-pushed
the
2024-07-update-lsps1
branch
5 times, most recently
from
ed65742 to
b014a08
Compare
.. to make it easier to switch back-and-forth when testing.
We previously didn't advertise the supported protocols, even if the corresponding service handlers were available.
.. as of LSPS#101.
tnull
force-pushed
the
2024-07-update-lsps1
branch
2 times, most recently
from
87e37fd to
177ff80
Compare
|
CI failure on the |
arik-so
reviewed
Dec 3, 2024
.. we tremendously simplify the client logic, also dropping any state tracking for now (possibly to be re-added in the future). We also get the LSPS1 API closer to LSPS2 and make sure the API/docs is more consistent. To this end, we also rename a bunch of types (`OrderParams`->`OrderParameters`, `OptionsSupported`->`LSPS1Options`) for improved clarity and, since we're not using them, drop the `AChannelManager` and `Filter` arguments of `LSPS1ClientHandler`.
.. as we have no real way to check the network at the point of deserialzation, and we want to handle `bitcoin::Addresses`, not uncheck addresses, in particular when it comes to serialization.
We allow de/serializing if the field is absent and mirror it back in `CreateOrderResponse`, as per recent spec change.
.. as per spec.
tnull
force-pushed
the
2024-07-update-lsps1
branch
from
177ff80 to
4a9af52
Compare
arik-so
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Closes #144
Closes #146
We refactor LSPS1-related client code and remove the
cfggate for these parts. Should be good for review, we can always iterate to improve the API etc. over time.