This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Expose lsps0_message_handler.handle_request
#15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanganto
changed the title
lsps0_message_handler.handle_request
yanganto
force-pushed
the
expose-handler-request
branch
from
58ba8f2 to
111ab58
Compare
tnull
reviewed
Jul 27, 2023
| @@ -1,3 +1,4 @@ | |||
| #![allow(missing_docs)] | |||
There was a problem hiding this comment.
We set #![deny(missing_docs)] crate-wide for good reason and def. should allow them here.
There was a problem hiding this comment.
Is there demo client to request on the public interface of lsp handler? It will be nice for people to check after integrate the handler. Many thanks.
There was a problem hiding this comment.
I think @johncantrell97 has a branch of ldk-sample with the LSP client and LSPS2 integrated.
@johncantrell97, mind sharing a link here?
There was a problem hiding this comment.
I forget the state it's in but I think it was working: https://github.com/johncantrell97/ldk-sample/pull/1/files
This was referenced Jul 31, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would
lsps0_message_handler.handle_requestbe public and return the response?Such that people integrate the handler will easier to verify the handler work after integration.
Thanks in advance. 🙏