DRY up end_to_end test in dns-resolver
#3830
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move code with flow paying for an offer into a function and use it in the test.
|
👋 Thanks for assigning @carlaKC as a reviewer! |
wpaulino
approved these changes
Jun 5, 2025
|
@elnosh might want to push again to see if it fixes CI? |
|
I hit "re-run failed" - hopefully that does the trick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on this comment #3808 (comment) to dry up the
end_to_endtest. That PR added a new case to test paying an offer with apayer_noteso the code with the flow of paying the offer in the test is repeated. Moved it into a function here and used in the test.