Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

move react-scripts to devDeps #1039

Closed

Conversation

hackerrdave
Copy link

react-scripts is only needed for development work - moving this to devdeps helps to reduce prod module size and npm audit noise for production modules (react-scripts is responsible for most of the npm audit warnings)

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2019

CLA assistant check
All committers have signed the CLA.

@hackerrdave hackerrdave force-pushed the react-scripts-devdep branch from 6942936 to 27471e4 Compare April 1, 2019 22:05
@tanx
Copy link
Contributor

tanx commented Apr 2, 2019

Thanks for the PR. I just tried this locally and npm audit --production still gives the warnings.

Closing this in favor of #1040

@tanx tanx closed this Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants