Skip to content

Fix Let's Encrypt issue #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Fix Let's Encrypt issue #9

merged 1 commit into from
Sep 7, 2018

Conversation

junderw
Copy link
Contributor

@junderw junderw commented Jan 24, 2018

Using github.com/golang/crypto at their most recent version includes http support for the LE challenge.

golang/crypto@13931e2

13 days ago they added this as a workaround to the issues where LE has removed the other challenge methods due to a vuln.

For now HTTP is the only method available to go's acmecert package.

Some of the glide dependencies in glide.lock got borked when I ran glide update... so I will leave the branch open to edits from maintainers.

This branch currently builds for us and works fine.

Thanks.

@dabura667
Copy link

@Roasbeef ping. The official faucet is grandfathered in to the old way of performing Let's Encrypt.

The current repository will not work for any new domains. This pull request does work for all new domains.

@dabura667
Copy link

@halseth @Roasbeef this is still broken.

Starting up a new faucet with a new domain is broken... the only reason your faucet still works is because you were grandfathered into Let’s Encrypt’s verification method you are using.

If you let your LE lapse even once, your site will no longer work until you merge this.

@Roasbeef
Copy link
Member

Roasbeef commented Sep 7, 2018

Oops, realized I didn't have notifications turned on for this repo!

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍺

@Roasbeef Roasbeef merged commit 23aa865 into lightninglabs:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants