Skip to content

Comments

build: bump go to v1.25.5#1236

Open
ZZiigguurraatt wants to merge 1 commit intolightninglabs:masterfrom
ZZiigguurraatt:bump-go-1.25.5
Open

build: bump go to v1.25.5#1236
ZZiigguurraatt wants to merge 1 commit intolightninglabs:masterfrom
ZZiigguurraatt:bump-go-1.25.5

Conversation

@ZZiigguurraatt
Copy link
Contributor

needed to build with latest lnd master

@gemini-code-assist
Copy link

Summary of Changes

Hello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Go programming language version used throughout the project to 1.25.5. This essential upgrade ensures compatibility with the latest lnd master branch, allowing the project to build successfully and leverage the most recent language features and improvements. The change impacts build configurations, Docker images, and Go module definitions across the repository.

Highlights

  • Go Version Update: The project's Go version has been updated across all relevant files from 1.24.11 to 1.25.5.
  • Docker Image Updates: Dockerfiles for various components (main, dev, litrpc, builder, tools) have been updated to use the new golang:1.25.5 base images with their corresponding SHA256 digests.
  • Module File Updates: All go.mod files within the main project and its sub-modules (autopilotserverrpc, litrpc, perms, tools, tools/linters) have been updated to reflect the new Go version requirement.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Dockerfile
    • Updated the Go base image from golang:1.24.11-alpine3.22 to golang:1.25.5-alpine3.23 and its SHA256 digest.
  • Makefile
    • Updated the GO_VERSION variable from 1.24.11 to 1.25.5.
  • autopilotserverrpc/go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
  • dev.Dockerfile
    • Updated the Go base image from golang:1.24.11-alpine3.22 to golang:1.25.5-alpine3.23 and its SHA256 digest.
  • go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
  • litrpc/Dockerfile
    • Updated the Go base image from golang:1.24.11-bookworm to golang:1.25.5-bookworm and its SHA256 digest.
  • litrpc/go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
  • make/builder.Dockerfile
    • Updated the Go base image from golang:1.24.11-bookworm to golang:1.25.5-bookworm and its SHA256 digest.
  • perms/go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
  • tools/Dockerfile
    • Updated the Go base image from golang:1.24.11-bookworm to golang:1.25.5-bookworm and its SHA256 digest.
  • tools/go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
  • tools/linters/go.mod
    • Updated the required Go version from 1.24.11 to 1.25.5.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/main.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.24.11 to 1.25.5 across the project, including go.mod files, Makefile, and Docker images. The changes are mostly consistent. However, I've pointed out a potential issue in Dockerfile and dev.Dockerfile where the final runtime image's Alpine version is not updated to match the new builder image's Alpine version. This could lead to runtime instability.

# The first stage is already done and all static assets should now be generated
# in the app/build sub directory.
FROM golang:1.24.11-alpine3.22@sha256:fb828ef85a4c4140fae45f145a84ca9c0a83fd0baa437a301b35b551e91ceed5 as golangbuilder
FROM golang:1.25.5-alpine3.23@sha256:ac09a5f469f307e5da71e766b0bd59c9c49ea460a528cc3e6686513d64a6f1fb as golangbuilder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The builder image is being updated to use an alpine3.23-based image, but the final runtime image on line 53 is still using alpine:3.22.1. This version mismatch between the build environment and the runtime environment can lead to subtle bugs or runtime failures due to library incompatibilities (e.g., musl version). To ensure consistency and prevent potential issues, the final image should also be updated to a corresponding alpine3.23 base.

# The first stage is already done and all static assets should now be generated
# in the app/build sub directory.
FROM golang:1.24.11-alpine3.22@sha256:fb828ef85a4c4140fae45f145a84ca9c0a83fd0baa437a301b35b551e91ceed5 as golangbuilder
FROM golang:1.25.5-alpine3.23@sha256:ac09a5f469f307e5da71e766b0bd59c9c49ea460a528cc3e6686513d64a6f1fb as golangbuilder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The builder image is being updated to use an alpine3.23-based image, but the final runtime image on line 130 is still using alpine:3.22.1. This can lead to runtime issues due to library inconsistencies between the build and run environments. The final image should also be updated to a corresponding alpine3.23 base to maintain consistency.

Copy link
Contributor

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants