build: bump go to v1.25.5#1236
Conversation
Summary of ChangesHello @ZZiigguurraatt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Go programming language version used throughout the project to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.24.11 to 1.25.5 across the project, including go.mod files, Makefile, and Docker images. The changes are mostly consistent. However, I've pointed out a potential issue in Dockerfile and dev.Dockerfile where the final runtime image's Alpine version is not updated to match the new builder image's Alpine version. This could lead to runtime instability.
| # The first stage is already done and all static assets should now be generated | ||
| # in the app/build sub directory. | ||
| FROM golang:1.24.11-alpine3.22@sha256:fb828ef85a4c4140fae45f145a84ca9c0a83fd0baa437a301b35b551e91ceed5 as golangbuilder | ||
| FROM golang:1.25.5-alpine3.23@sha256:ac09a5f469f307e5da71e766b0bd59c9c49ea460a528cc3e6686513d64a6f1fb as golangbuilder |
There was a problem hiding this comment.
The builder image is being updated to use an alpine3.23-based image, but the final runtime image on line 53 is still using alpine:3.22.1. This version mismatch between the build environment and the runtime environment can lead to subtle bugs or runtime failures due to library incompatibilities (e.g., musl version). To ensure consistency and prevent potential issues, the final image should also be updated to a corresponding alpine3.23 base.
| # The first stage is already done and all static assets should now be generated | ||
| # in the app/build sub directory. | ||
| FROM golang:1.24.11-alpine3.22@sha256:fb828ef85a4c4140fae45f145a84ca9c0a83fd0baa437a301b35b551e91ceed5 as golangbuilder | ||
| FROM golang:1.25.5-alpine3.23@sha256:ac09a5f469f307e5da71e766b0bd59c9c49ea460a528cc3e6686513d64a6f1fb as golangbuilder |
There was a problem hiding this comment.
The builder image is being updated to use an alpine3.23-based image, but the final runtime image on line 130 is still using alpine:3.22.1. This can lead to runtime issues due to library inconsistencies between the build and run environments. The final image should also be updated to a corresponding alpine3.23 base to maintain consistency.
ViktorT-11
left a comment
There was a problem hiding this comment.
Thanks! Looks good after the review bot's comments have been addressed, i.e https://github.com/lightninglabs/lightning-terminal/pull/1236/changes#r2828525741
&
https://github.com/lightninglabs/lightning-terminal/pull/1236/changes#r2828525735
needed to build with latest lnd master