Adding setting price_oracle_metadata via addinvoice CLI

[sergey3bv]

Should close #1194

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the addinvoice CLI command by introducing a new price_oracle_metadata flag. This allows users to include opaque metadata with their invoices, which can be utilized by a price oracle. The change provides greater flexibility for integrating external pricing mechanisms while ensuring data integrity through size validation. Additionally, several build tags were updated and mock configurations simplified.

Highlights

• New CLI Flag: Introduced a new price_oracle_metadata flag to the addinvoice CLI command, allowing users to attach arbitrary metadata to invoices.
• Metadata Validation: Implemented validation logic for the price_oracle_metadata to ensure it adheres to a maximum size limit of 32768 bytes.
• Build Tag Updates: Updated various itest files to include a //go:build dev tag, affecting how integration tests are built.
• Mock Configuration Simplification: Refactored perms/mock.go by removing unused imports and simplifying mock configurations for several RPC services.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new price_oracle_metadata flag to the addinvoice command in litcli, allowing users to provide optional opaque metadata. The changes include a new validation utility, corresponding unit tests, and the integration of this metadata into the invoice creation request. Additionally, //go:build dev tags were added to multiple integration test files, and mock configurations in perms/mock.go were simplified by removing several internal dependencies. I have no feedback to provide.

[lightninglabs-deploy]

@sergey3bv, remember to re-request review from reviewers when ready