firewall: fix 32-bit int truncation and optimize CryptoRandIntn#1358
firewall: fix 32-bit int truncation and optimize CryptoRandIntn#1358bitromortac wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential integer truncation issues on 32-bit architectures by standardizing the use of int64 for random number generation and related calculations. It also introduces performance optimizations for cryptographic random number generation by reusing big.Int objects via a sync.Pool, which improves efficiency during high-frequency operations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the privacy mapper to use int64 instead of int for random number generation, preventing architecture-dependent truncation on 32-bit systems. It also introduces a sync.Pool for *big.Int to optimize allocations in CryptoRandIntn and adds tests for 32-bit overflow. A potential bug was identified in hideAmount where the randomized upper bound amountMax can still overflow int64 and cause a signed integer wrap-around, leading to failures in randBetween.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Upgrade the randIntn function signature from int to int64 to prevent unpredictable integer truncation on 32-bit systems (e.g., Raspberry Pi). This ensures UnixNano timestamps in hideTimestamp and large amounts in hideAmount do not cause unexpected runtime failures when calling ForwardingHistory.
Utilize a sync.Pool for *big.Int instances in CryptoRandIntn to avoid frequent heap allocations. This significantly reduces garbage collection pressure when randomizing timestamps, amounts, and fees inside loops (e.g. iterating over forwarding history responses).
Add a succinct release note entry detailing the 32-bit truncation prevention and allocation optimization introduced by PR-1358.
3813ffd to
1eddc53
Compare
2 participants
Fixes integer truncation on 32-bit runtimes by promoting the signature of
randIntnand its fuzzer helpers from int to int64. This ensuresUnixNanotimestamps and large satoshi amounts do not overflow or truncate when callingForwardingHistory.Additionally, optimizes CryptoRandIntn by introducing a
sync.Poolfor*big.Intallocations, eliminating heap allocation overhead and GC pressure when fuzzing large lists of records in loop bodies.Fixes #1357