Front-end integration for disabled subservers#620
Merged
Conversation
itsrachelfish
force-pushed
the
disabled-subservers
branch
2 times, most recently
from
August 9, 2023 20:58
de981bf to
b8edfc8
Compare
itsrachelfish
marked this pull request as ready for review
August 9, 2023 21:01
itsrachelfish
force-pushed
the
disabled-subservers
branch
from
August 14, 2023 17:57
935ea43 to
62e7b9e
Compare
jbrill
suggested changes
Aug 14, 2023
|
Also for the svg, we might want to tweak the color to be |
Contributor
|
ACK to @jbrill's SVG comment! Always have to remember that one when dealing with icons 😂 |
jbrill
reviewed
Aug 16, 2023
itsrachelfish
force-pushed
the
disabled-subservers
branch
3 times, most recently
from
August 23, 2023 18:19
43f32c7 to
538f582
Compare
itsrachelfish
force-pushed
the
disabled-subservers
branch
2 times, most recently
from
August 24, 2023 07:33
4b32e5b to
e340e62
Compare
itsrachelfish
force-pushed
the
disabled-subservers
branch
from
September 11, 2023 07:10
e340e62 to
070fdd0
Compare
|
@jbrill: review reminder |
jbrill
reviewed
Sep 21, 2023
jamaljsr
approved these changes
Sep 22, 2023
jamaljsr
left a comment
jamaljsr
left a comment
Member
There was a problem hiding this comment.
tACK. Great work on this @itsrachelfish! I tested and confirmed both the disabled and error statuses. The functionality is good to go, so approved from my end.
I left some comments on code improvements that could be made if time permits, or saved for a follow-up PR.
guggero
force-pushed
the
disabled-subservers
branch
from
September 23, 2023 07:09
070fdd0 to
861d64c
Compare
jbrill
approved these changes
Sep 25, 2023
This was referenced Sep 25, 2023
ellemouton
force-pushed
the
disabled-subservers
branch
from
September 25, 2023 13:05
2d2e473 to
c6a24e7
Compare
itsrachelfish
force-pushed
the
disabled-subservers
branch
4 times, most recently
from
September 25, 2023 21:44
ed9264e to
fa9e3d7
Compare
itsrachelfish
force-pushed
the
disabled-subservers
branch
3 times, most recently
from
September 27, 2023 01:53
54d04cb to
e29cfe9
Compare
jamaljsr
reviewed
Sep 27, 2023
jamaljsr
left a comment
jamaljsr
left a comment
Member
There was a problem hiding this comment.
Fantastic update! The code looks so much cleaner now.
Just have one more small suggestion.
itsrachelfish
force-pushed
the
disabled-subservers
branch
from
September 27, 2023 09:54
e29cfe9 to
c223c40
Compare
jbrill
approved these changes
Sep 28, 2023
jbrill
left a comment
jbrill
left a comment
There was a problem hiding this comment.
Looks great! Thanks for the updates! 🚀
ellemouton
force-pushed
the
disabled-subservers
branch
from
September 28, 2023 16:23
c223c40 to
5ff3863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new SubServerStatus store which checks which services are being run by litd. When loop and pool are not running or are in an error state, the page displays an error message:
Depends on #541