-
Notifications
You must be signed in to change notification settings - Fork 103
Bump litd to version v0.12.5-alpha
#750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump litd to version v0.12.5-alpha
#750
Conversation
We've decided to cut the release before merging #746. I've tested this locally with the terminal web UI, and the Loop & Pool flow worked as expected for me. I've also tested the Autopilot flow locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎸
688314c
to
299b12d
Compare
Updated the PR with a commit that updates the wording in the Compatibility section in the README, to make it clearer what the first table details. I'm just re-requesting a review from you @ellemouton, to verify that you agree with the new wording :)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor suggestions
README.md
Outdated
This version compatibility dependency table is only relevant when running `lnd` | ||
in remote mode, and shows the **_minimum_** `lnd` version that can be used with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"when running lnd
in remote mode" -> technically LND cant be run in remote mode. It is a mode of "litd". So perhaps just "when running litd
in remote mode" or if we want to be more descriptive: "when running litd
in remote mode (meaning that lnd
is running as a separate process to litd
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good clarification suggestion :)! I updated this, but changed the "(meaning that ... )" section a little to:
"This version compatibility dependency table is only relevant when running litd in remote mode (meaning that lnd-mode=remote
is set)."
I think that should be pretty clear to most users. The only con with my new version is that we don't mention the operating modes of Litd until after the table, but I think it should be understandable either way.
If we would like to address that con though, I think it would also make sense to move the entire section of "Full Lightning Terminal functionality can be dependent on running a compatible version of lnd
..." + the version compatibility dependency table. I'd suggest we'd then move it so it's written after the "supported combinations table".
Let me know if you think the current version is ok, or if you'd like me to move the section!
The wording for the first table of the Compatibility section of the README was confusing, as it didn't clearly state that the table showed the _minimum_ `lnd` version that can be used for different litd versions, when lnd is running in remote mode. This commit updates the wording in that section to make that clearer.
Bump lnd to version `v0.17.5-beta` and loop to version `v0.28.1-beta`.
299b12d
to
397502e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This PR bumps the litd version to
v0.12.5-alpha
.This PR also bumps lnd to version
v0.17.5-beta
and loop tov0.28.1-beta
.We've not yet decided if we'll wait for #746 to be merged before the release, so I'm therefore pushing this as draft until we've made a decision regarding that.