itests: add asset force close itest #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
reviewed
Jun 21, 2024
Member
GeorgeTsagk
left a comment
GeorgeTsagk
left a comment
There was a problem hiding this comment.
something in the dependencies is off
itest doesn't compile
itest/litd_custom_channels_test.go
Outdated
| // With the channel open, mine a block to confirm it. | ||
| mineBlocks(t, net, 6, 1) | ||
|
|
||
| time.Sleep(time.Second * 2) |
Member
There was a problem hiding this comment.
nit: is this really needed? mineBlocks is a blocking call
|
|
||
| // With the payments sent, we'll now go on chain with a force close | ||
| // from Carol. | ||
| t.Logf("Force closing channel...") |
Member
There was a problem hiding this comment.
nit: could also make some payments from dave to charlie for extra coverage
guggero
force-pushed
the
custom-channels-integration-force-close
branch
from
c924fe6 to
98114f0
Compare
Contributor
|
Pushed some updates to make things compile. |
GeorgeTsagk
approved these changes
Jun 21, 2024
Member
GeorgeTsagk
left a comment
GeorgeTsagk
left a comment
There was a problem hiding this comment.
ty @guggero for the fixes
LGTM ✔️
pending some nits from above, but non-blocking
Roasbeef
force-pushed
the
custom-channels-integration-force-close
branch
from
98114f0 to
b7a9d07
Compare
Member
Author
|
Have a breach follow up coming in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add the
AuxSweeper, update the lnd+tapd dependancies, and also add an initial force close itest.