itest: add BTC-only keysend and invoice payments #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
approved these changes
Jun 21, 2024
| // We should also be able to do a multi-hop BTC only payment, paying an | ||
| // invoice from Erin by Charlie. | ||
| createAndPayNormalInvoiceWithBtc(t.t, charlie, erin, 2000) | ||
| logBalance(t.t, nodes, assetID, "after BTC only invoice") |
There was a problem hiding this comment.
does this also assert that the balance is as expected?
There was a problem hiding this comment.
No, but we do that later. That's just for visual confirmation. And currently we don't track and/or assert the BTC balance. But since we don't really change any logic in the BTC-only flow, just making sure the payment arrives should be enough.
To make sure asset channels also function properly with BTC-only payments, we add a keysend and invoice payment to the integration tests.
jamaljsr
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure asset channels also function properly with BTC-only
payments, we add a keysend and invoice payment to the integration tests.