-
Notifications
You must be signed in to change notification settings - Fork 103
itest: Add custom channels with grouped asset test #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itest: Add custom channels with grouped asset test #781
Conversation
Looks like the grouped asset itest fails consistently when sending a payment. Does that happen as well for you locally? |
Nope, locally it passes consistently, and on Github CI it's flaky |
0046505
to
fb870e4
Compare
b52ee68
to
91372ac
Compare
The flake will be fixed by lightningnetwork/lnd#8871. Not sure if we should get this in while flakey and then wait for the CI to become fully green in #782 which bumps all dependencies? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I'm in favor of merging this, even if the itest doesn't pass yet. I've confirmed that lightningnetwork/lnd#8871 will fix this, so it's just a matter of bumping the lnd
dependency after merge, which #782 will do anyway.
I'm fine both ways, since we know it's a flake we could hit the merge prematurely |
4b0c87f
to
7805c4d
Compare
32a9735
to
77b6af9
Compare
Description
This PR adds a new itest that uses a grouped asset, in order to tackle some of the issues discovered in lightninglabs/taproot-assets#947
Closes lightninglabs/taproot-assets#957