itest: refactor, add more assertions #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Jul 1, 2024
|
Made this PR to fix the import issue: lightninglabs/taproot-assets#987 Will update this with the latest commit to rerun the itests. |
This commit extracts the creation of the asset test channel network into its own function. At the same time we also move all helper functions to a new file.
This makes sure that a recipient of a channel can also initiate the co-op closing procedure and everything works the same still.
We should only have 2 outputs, the test asserted 3 before as the co-op close transaction couldn't properly spend the funding input. We also assert the normal balance now as now that we import the funding outputs as proofs, this no longer incorrectly shows up as the balance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more assertions after refactoring out some common code.
The new assertions discovered the following bugs: