Bump litd to version v0.13.4-alpha
#843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,10 +1,10 @@ | |||
| # Start with a NodeJS base image that also contains yarn. | |||
| FROM node:16.14.2-buster as nodejsbuilder | |||
| FROM node:22.8.0-bookworm as nodejsbuilder | |||
There was a problem hiding this comment.
@jamaljsr, let me know if you think this NodeJS base image version is ok, or if you'd like me to use 18.20-bookworm instead :)!
There was a problem hiding this comment.
I tested this and it works for me, so this is fine.
I would suggest bumping the image version in Dockerfile and dev.Dockerfile as well, just to be consistent.
|
Sorry, will solve the failing CI checks asap! |
ViktorTigerstrom
force-pushed
the
2024-09-litd_0_13_4
branch
from
eeae48f to
a276d88
Compare
ellemouton
approved these changes
Sep 13, 2024
jamaljsr
approved these changes
Sep 13, 2024
| @@ -1,10 +1,10 @@ | |||
| # Start with a NodeJS base image that also contains yarn. | |||
| FROM node:16.14.2-buster as nodejsbuilder | |||
| FROM node:22.8.0-bookworm as nodejsbuilder | |||
There was a problem hiding this comment.
I tested this and it works for me, so this is fine.
I would suggest bumping the image version in Dockerfile and dev.Dockerfile as well, just to be consistent.
In the next commit, we'll bump our lnd dependency to `v0.18.3-beta`. That version adds explicitly declared optional protos fields with commit lightningnetwork/lnd@3de6c54 Optional proto fields are only available in Proto3 after protoc version `3.15+`, and we therefore need to bump our protoc version for the protos generation script to support them. When doing so, we mimic the protobuf-compiler version used in `lnd`, which is `3.21.12`. As protobuf-compiler 3.21.x+ is only available for Node.js base images with Debian 12 (bookworm), we also update our NodeJS base image to version 22.8.0-bookworm.
Bump lnd to v0.18.3-beta & loop to v0.28.7-beta. Also bump lnd/sqldb to v1.0.4, as it's required by lnd v0.18.3-beta.
ViktorTigerstrom
force-pushed
the
2024-09-litd_0_13_4
branch
2 times, most recently
from
e8ab33a to
c788a46
Compare
ellemouton
reviewed
Sep 16, 2024
ViktorTigerstrom
force-pushed
the
2024-09-litd_0_13_4
branch
from
c788a46 to
8527c62
Compare
ViktorTigerstrom
force-pushed
the
2024-09-litd_0_13_4
branch
from
8527c62 to
9bc30fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the litd version to
v0.13.4-alpha.This PR also bumps lnd to version
v0.18.3-beta& loopv0.28.7-beta.As lnd
v0.18.3-betaadds explicitly declared optional protos fields with commit lightningnetwork/lnd@3de6c54, we this PR also needed to update the protoc version used for the protos generation script. Optional proto fields are only available in Proto3 after protoc version3.15+.When doing so, we mimic the protobuf-compiler version used in
lnd, which is3.21.12. As protobuf-compiler 3.21.x+ is only available for Node.js base images with Debian 12 (bookworm), we also update our NodeJS base image to version 22.8.0-bookworm.