docs: backdated and new release notes#1181
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
b7e78e7 to
63e4227
Compare
| @@ -1,2 +1,3 @@ | |||
| #### Pull Request Checklist | |||
| - [ ] Update `release_notes.md` if your PR contains major features, breaking changes or bugfixes | |||
| - [ ] Update `docs/release-notes/release-notes-template.md` if your PR contains | |||
There was a problem hiding this comment.
It should be not the template here. We need another growing file for a future release. Like docs/release-notes/release-notes-next.md
|
Missing releases: v0.1.3-beta, v0.2.0-alpha, v0.6.1-beta, v0.15.1-beta, v0.25.0-beta, v0.25.1-beta, v0.26.1-beta, v0.31.3-beta, v0.31.5-beta-lnd0.20, and v0.31.6-beta. Consequently, previous/next navigation also skips real tags, for example
The |
Document every published Loop release and preserve authoritative notes. Add the next-release workflow and rebuild chronological navigation. Rename the reproducible-build guide for clarity.
|
Thanks for the detailed review @starius, I've addressed all issues you found! |
starius
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Pending comments:
-
The historical
v0.6.2-betadescription was lost.The current page
docs/release-notes/release-notes-0.6.2.md:11says it contains only version-metadata changes. However, the historical upstream release describes:- native SegWit Loop In HTLC support;
- the Multi-Loop Out maximum-payment-parts fix.
Those ideas were moved to the new
v0.6.1-betapage because that matches the code history, but the requirement says a published historical description must remain represented on its release page.v0.6.2-betashould retain that description, possibly with a note explaining the tag-to-tag delta. -
The early release sequence runs backward.
The index
docs/release-notes/README.md:18currently orders:v0.1.3-alpha → v0.1.3-beta → v0.2-alphaBut the current upstream
v0.1.3-betacommit is an ancestor ofv0.1.3-alpha; GitHub reports the beta tag as zero commits ahead and twelve behind: upstream comparison.The source-linear order should be:
v0.1.2-alpha → v0.1.3-beta → v0.1.3-alpha → v0.2-alpha → v0.2.0-alphaNavigation and contributor sections need recalculating after that change. In particular, the
v0.2-alphapagedocs/release-notes/release-notes-0.2.md:150currently lists only Olaoluwa, while thev0.1.3-beta...v0.2-alpharange also contains commits by Joost Jager and Valentine Wallace.
This PR adds a
docs/release-notesfolder and adds backdated release notes.