Skip to content

go.sum: run go mod tidy to cleanup old dependencies #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

carlaKC
Copy link
Contributor

@carlaKC carlaKC commented Oct 12, 2020

go mod tidy (which our current modules check relies on) does not detect items that should be deleted in go.sum, this has recently been addressed in go, so we can wait on the fix. In the meantime, this PR cleans up our go.sum.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhandras
Copy link
Member

Out of curiosity, how did you find these old deps?

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@carlaKC
Copy link
Contributor Author

carlaKC commented Oct 12, 2020

Out of curiosity, how did you find these old deps?

When you make a change that does need to change go.sum, then modules pick up that there are stale entries. So I got a diff I wasn't expecting in #295.

@carlaKC carlaKC merged commit 15a400b into lightninglabs:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants