tapchannel: ensure genesis proofs for input assets already known #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
universe-sync-on-fund
branch
from
c4755f6 to
4bf3a50
Compare
jharveyb
reviewed
Jul 16, 2024
jharveyb
approved these changes
Jul 16, 2024
Roasbeef
force-pushed
the
universe-sync-on-fund
branch
from
4bf3a50 to
a424df2
Compare
With this commit, we partially address #1026 by ensuring that when we receive an incoming funding request, then we've already verified the genesis proofs of the incoming asset. If we haven't verified the proofs yet, then we'll try to fetch from a remote universe. Otherwise, this check will be a noop.
Before this commit, we wouldn't auto unlock the inputs if any of the actions after coin selection failed.
Roasbeef
force-pushed
the
universe-sync-on-fund
branch
from
a424df2 to
575e262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we partially address #1026 by ensuring that when we
receive an incoming funding request, then we've already verified the
genesis proofs of the incoming asset.
If we haven't verified the proofs yet, then we'll try to fetch from a
remote universe. Otherwise, this check will be a noop.