Skip to content

Remove lnd references in user-visible issue copy #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

dstadulis
Copy link
Contributor

When clicking "New Issue", the copy in the label referenced lnd which is confusing given expectations are to create a taproot-assets issue

When clicking "New Issue", the copy in the label referenced lnd which is confusing given expectations are to create a taproot-assets issue
@ffranr ffranr self-requested a review July 5, 2023 18:58
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I glazed over that in the previous PR!

@dstadulis
Copy link
Contributor Author

Not sure why I glazed over that in the previous PR!

wasn't clear (to me at least) this copy would have been shown to users

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧿

@Roasbeef Roasbeef added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 7a5d5ca Jul 5, 2023
@jharveyb jharveyb deleted the remove-lnd-references branch July 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants