Skip to content

[Windows] Test coverage missing for part of User home dir setup login on Windows #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arixmkii opened this issue Mar 19, 2025 · 0 comments · Fixed by #3378
Closed

[Windows] Test coverage missing for part of User home dir setup login on Windows #3364

arixmkii opened this issue Mar 19, 2025 · 0 comments · Fixed by #3378

Comments

@arixmkii
Copy link
Contributor

Description

Identified by this comment #3304 (comment)

There is non-trivial piece of code for deriving user home in guest VM using cygpath/wslpath. Both a similar, but have behavior differences and could have configuration differences.

For testing purposes this could would need to be refactored and mocks created for the tools themselves.

The thing to think about is. May be this code can be removed at all, because it is followed up by

if home == "" {
which is re-implementation of basics of the cygpath processing Windows paths into Unix (default msys2 configuration, no FS customizations). May be this is really sufficient for the case, especially because the path from the tools has to be updated with some sort of prefix and is not used directly (to prevent collision with mounts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant