-
Notifications
You must be signed in to change notification settings - Fork 660
Improve Subsystem paths handling on Windows hosts #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jandubois please take a look |
I'm sorry, I hoped I would be able to review (test, actually) this change before having to leave on a trip, but I've run out of time. Unless some other maintainer picks this up, it will have to wait until I'm back online in April. |
Needs rebase |
Signed-off-by: Arthur Sengileyev <[email protected]>
61f1e83
to
848f704
Compare
Rebased |
home = strings.TrimPrefix(home, prefix) | ||
} | ||
home += ".linux" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This complicated logic should have unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to write a test for this one, but this have some heavy dependencies. It needs cygpath, which is mostly fine for Windows specific cases, but for wslpath - one needs WSL distribution as it is available only inside container.
At some point I had idea to remove this part entirely and rely only on hand coded cygpath alternative in the code below this (the second conditional branch), as for the purpose of creating home directory it was good enough.
I will create a ticket, where I summarize what options are available to improve situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fixes #3303
Implemented changes
I did local testing with WSL2, plan to test this with QEMU, when I rebase my current experimental branch,