Enable trimming QEMU disks #1102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would enable trimming of QEMU virtual disks, by adding the
discard=on
argument to-drive
flag forbasedisk
ordiffdisk
. As a result, runningfstrim -a
in the guest would reduce the disk space consumed by QEMU disks (basedisk
ordiffdisk
), and reduce the disk usage of Lima guests.Current behavior: there's no easy way to reduce the disk usage of
diffdisk
, and runningfstrim -a
in the guest has no effect.Resolves #356