Support compressed image files with os/exec #1439
Conversation
pkg/downloader/downloader.go
Outdated
| default: | ||
| return fmt.Errorf("decompressLocal: unknown extension %s", ext) | ||
| } | ||
| logrus.Infof("decompressing %s with %s", ext, program) |
There was a problem hiding this comment.
| logrus.Infof("decompressing %s with %s", ext, program) | |
| logrus.Debugf("decompressing %s with %s", ext, program) |
There was a problem hiding this comment.
There is a looong pause here, when using some of the slower compressions like bzip2 or xz
There was a problem hiding this comment.
Maybe we should consider printing progress bars?
There was a problem hiding this comment.
Right, but that would seem to imply not calling os/exec but using something like archiver ?
There was a problem hiding this comment.
You can just use io.MultiWriter(uncompressCmdStdin, progressBar).
Can be another PR.
There was a problem hiding this comment.
Also, we don't have any progress bars for the copy yet either (probably mostly shown for NFS)
| func TestDownloadCompressed(t *testing.T) { | ||
|
|
||
| if runtime.GOOS == "windows" { | ||
| // FIXME: `assertion failed: error is not nil: exec: "gzip": executable file not found in %PATH%` |
There was a problem hiding this comment.
We can use stdlib for gzip.
Can be another PR in the future
There was a problem hiding this comment.
I'm not sure if anyone is using gzip, because I think the image format supports this natively ?
Fork an external program, rather than linking everything. Keep some files compressed, such as the nerdctl-full tgz. Signed-off-by: Anders F Björklund <[email protected]>
Fork an external program, rather than linking everything.
(like https://github.com/mholt/archiver)
Keep some files compressed, such as the nerdctl-full tgz.
Closes #809