-
Notifications
You must be signed in to change notification settings - Fork 661
Include manpages for lima and limactl commands #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here is the LIMA 1 "May 2023" "" ""
=======================
# NAME
lima - Lima: Linux virtual machines
# SYNOPSIS
**lima** [_COMMAND_...]
# DESCRIPTION
lima is an alias for "limactl shell default".
The instance name ("default") can be changed by specifying $LIMA\_INSTANCE.
The shell and initial workdir inside the instance can be specified via $LIMA\_SHELL
and $LIMA\_WORKDIR.
# SEE ALSO
**limactl**(1)
|
CI is failing
We can just allow |
The "limactl.1" and subcommands are being dynamically generated. There is one manual page for each subcommand, e.g. limactl-start Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR seems fine.
The auto-generated man pages look a bit sparse (I just compared man limactl-start
with man git-commit
and man kubectl-get
). I guess it would be a matter of improving the Cobra definitions for each command.
I also noticed that git commit --help
will invoke man git-commit
, which has better formatting than what Cobra does. I wonder if this is something we should consider (fwiw, kubectl
doesn't delegate to man
).
I think we should just use the default cobra output, and improve the descriptions in the code if it is needed. We could also generate markdown, and use that for a standalone documentation - like in a docs web site https://github.com/spf13/cobra/blob/main/doc/md_docs.md |
That's what I meant by "improving the Cobra definitions". Having separate (duplicate) docs for each subcommands is just not maintainable. |
I did some experiments with generating markdown and html, from cobra: master...afbjorklund:lima:markdown It's not perfect, since most of it is just blocks of performatted text (at best) |
The "limactl.1" and subcommands are being dynamically generated.
There is one manual page for each subcommand, e.g. limactl-start
https://github.com/spf13/cobra/blob/main/doc/man_docs.md
There is also
help2man --no-info
, for individual commands