vz: fail early when arch is invalid#1575
Merged
AkihiroSuda merged 1 commit intolima-vm:masterfrom May 25, 2023
Merged
Conversation
balajiv113
reviewed
May 24, 2023
| case QEMU: | ||
| // NOP | ||
| case VZ: | ||
| if !IsNativeArch(*y.Arch) { |
Member
There was a problem hiding this comment.
Can we do this at driver validate method ?
https://github.com/lima-vm/lima/blob/master/pkg/vz/vz_driver_darwin.go#L38
Member
There was a problem hiding this comment.
I thought we can fully move this from here to individual driver level.
Whether the vmType is valid or not that should already be validated if am not wrong
Member
Author
There was a problem hiding this comment.
The point of this PR is to detect invalid arch as early as possible, i.e., limactl validate
Member
There was a problem hiding this comment.
Okay got it.
Maybe in near future we could offload driver related validation to driver itself. I will create a follow up issue later to handle this
AkihiroSuda
force-pushed
the
vz-faily-early-invalid-arch
branch
from
4412466 to
9f102bc
Compare
balajiv113
previously approved these changes
May 24, 2023
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
vz-faily-early-invalid-arch
branch
from
9f102bc to
fecf6ed
Compare
balajiv113
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.