Allow changing prefix for the installations #1655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Jul 4, 2023
jandubois
reviewed
Jul 4, 2023
afbjorklund
force-pushed
the
prefix
branch
2 times, most recently
from
db25313 to
96e28c3
Compare
AkihiroSuda
reviewed
Jul 16, 2023
AkihiroSuda
reviewed
Jul 16, 2023
AkihiroSuda
reviewed
Jul 16, 2023
If /usr/local is read-only, you can override the prefix to use something like /opt instead. But it is assumed that /etc is always read-write... Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If /usr/local is read-only, you can override the prefix to use something like /opt instead. But it is assumed that /etc is always read-write...
Closes #1654
For some reason /opt/bin was not in the PATH of the check, even if it is the PATH of the actual user later on.
Workaround was to check with
test -xin addition tocommand -v, to see ifnerdctlhas been installed yet.