Add variable for the guest home directory #1736
Conversation
Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
guest-home
branch
from
473c6a2 to
b9e5e65
Compare
| @@ -151,6 +151,7 @@ The volume label is "cidata", as defined by [cloud-init NoCloud](https://cloudin | |||
| - `LIMA_CIDATA_MNT`: the mount point of the disk. `/mnt/lima-cidata`. | |||
| - `LIMA_CIDATA_USER`: the user name string | |||
| - `LIMA_CIDATA_UID`: the numeric UID | |||
| - `LIMA_CIDATA_HOME`: the guest home directory | |||
There was a problem hiding this comment.
Maybe:
| - `LIMA_CIDATA_HOME`: the guest home directory | |
| - `LIMA_CIDATA_USER_HOME`: the guest home directory (`/home/foo.linux`) |
Because we may potentially use LIMA_CIDATA_HOME for something like LIMA_HOME which is not a user home directory?
There was a problem hiding this comment.
It was supposed to be simple wrappers for $USER and $HOME, we can give them long and strange names like USER_NAME and USER_HOME but I'm not sure it will help? Better do something like LIMA_CIDATA_HOSTHOME (or LIMA_CIDATA_HOST_LIMA_HOME, or whatever it would end up looking like) when needed
There was a problem hiding this comment.
This is not visible to end users anyway, so I don't have a strong opinion
|
It still duplicates the
Maybe it should even set Homedir in the |
Just a refactoring, to avoid hardcoding
/homeandlinuxeverywhere in cidata.