Don't download files that are already cached #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
AkihiroSuda
reviewed
Oct 3, 2023
AkihiroSuda
reviewed
Oct 3, 2023
AkihiroSuda
reviewed
Oct 3, 2023
|
Thanks, looks good but a couple of nits |
This will return any files already in the cache, with valid digest, but not download any new ones. Signed-off-by: Anders F Björklund <[email protected]>
The nerdctl archive has already been downloaded to the cache, so don't log downloading it again. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
start-download-log
branch
from
8ff7aa2 to
4efb676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nerdctl(-full) archive has already been downloaded to the cache (during
create),so don't log downloading it again (during
start) - unless file is missing or digest fails.Don't use files for different arch, or check for local files that are not available in the cache.
Refactor common methods out from the longer functions, so that they can be reused.
Closes #1875
Edit: it wasn't actually downloading the file again, just spamming the INFO log about it