Skip to content

test.yml: upload failure-logs as an artifact if test-templates.sh fails and failure-logs exists. #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

norio-nomura
Copy link
Contributor

I think tail "$HOME/.lima/${NAME}"/*.log is not sufficient.

Thanks,

@norio-nomura norio-nomura force-pushed the ci-uploads-failed-logs branch from 0c2df32 to 3646fe8 Compare July 24, 2024 03:03
@norio-nomura norio-nomura force-pushed the ci-uploads-failed-logs branch from 3646fe8 to b0550a2 Compare July 24, 2024 03:31
@norio-nomura
Copy link
Contributor Author

force pushed for

silence yamllint
test:yml: switch to if: always(), if the previous step uses retry
test.yml: change to failure-logs

@norio-nomura norio-nomura changed the title test.yml: upload failed-logs as an artifact if test-templates.sh fails and failed-logs exists. test.yml: upload failure-logs as an artifact if test-templates.sh fails and failure-logs exists. Jul 24, 2024
@norio-nomura norio-nomura force-pushed the ci-uploads-failed-logs branch 4 times, most recently from b882024 to 33d53c0 Compare July 24, 2024 05:52
…fails and `failed-logs` exists.

silence yamllint

test:yml: switch to `if: always()`, if the previous step uses `retry`

test.yml: change to `failure-logs`

upload_failure_logs_if_exists: fix error: required property is missing: shell

upload_failure_logs_if_exists: ensure the artifact name is unique.

upload_failure_logs_if_exists: normalize suffix input

upload_failure_logs_if_exists: add description comment to normalize-suffix

Signed-off-by: Norio Nomura <[email protected]>
@norio-nomura norio-nomura force-pushed the ci-uploads-failed-logs branch from 33d53c0 to 8741f67 Compare July 24, 2024 08:05
@norio-nomura
Copy link
Contributor Author

@AkihiroSuda AkihiroSuda added the area/test Tests and CI label Jul 25, 2024
@AkihiroSuda AkihiroSuda added this to the v0.22.1 milestone Jul 25, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit be93284 into lima-vm:master Jul 25, 2024
27 checks passed
@norio-nomura norio-nomura deleted the ci-uploads-failed-logs branch July 26, 2024 00:30
@norio-nomura
Copy link
Contributor Author

Thanks! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants