Allow separate rules for UDP port forwarding #2605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
forward-udp
branch
2 times, most recently
from
e098dd2 to
392f700
Compare
Additionally a Proto value of "any" would match both TCP and UDP ports. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
forward-udp
branch
from
392f700 to
9a09350
Compare
|
UDP port forwarding tests should go into a separate PR. This PR just makes it possible to have separate rules for TCP vs. UDP; without this PR the TCP rules were applied to UDP as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally a
Protovalue of"any"would match both TCP and UDP ports.The default for
Protoremainstcp, both for backwards compatibility, and becauseanyrarely makes sense, except e.g. when you want to disable all port forwarding for any protocol.We should also update
hack/test-portforwarding.plto cover UDP port forwarding as well. Maybe in a separate PR to allow for manual testing of UDP forwarding rules already.