Use loopback for SSH connection in WSL2 #3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3242
According to WSL2 documentation - both mainstream networking modes NAT and mirrored support access to WSL2 running apps via loopback https://learn.microsoft.com/en-us/windows/wsl/networking#accessing-linux-networking-apps-from-windows-localhost
Other Hyper-V networking modes as bridged and may be some others are somewhat supported by WSL2, but are discouraged for common scenarios.
In this case there is no point to resolve external IP in a distro specific way to successfully run Lima provisioning of the said VM.
I tested this with NAT in GH actions and with mirrored networking locally.
There are setting for preventing access via loopback but there are also firewalls, which would prevent to access over external IP, so, the loopback sounds like a reasonable default and different settings should only be used if specific scenario is detected or if specifically requested. As these scenarios are not documented as of now the code in question could be removed and later reintroduced adjusted to the new usecases.