feat: added a default `--yes` flag to set the tty #3342

suryaaprakassh · 2025-03-12T09:26:21Z

created a new boolean flag `--yes' or '-y' in shorthand
sets the value of --tty to false if used

cmd/limactl/main.go

jandubois

I wonder what should happen if the user specifies contradictory settings, like --tty --yes or --tty=false --yes=false.

You could say a later option should override an earlier one, but I don't know if that can easily be done with Cobra.

An alternative (and I suspect the correct one in this case) would be to throw an error instead of randomly picking one setting over the other.

AkihiroSuda · 2025-03-12T21:01:44Z

An alternative (and I suspect the correct one in this case) would be to throw an error instead of randomly picking one setting over the other.

👍 on this

Also, please squash the commits

suryaaprakassh · 2025-03-13T07:27:28Z

An alternative (and I suspect the correct one in this case) would be to throw an error instead of randomly picking one setting over the other.

changes have been made to throw an error when both --yes and --tty flag are used simultaneously

AkihiroSuda · 2025-03-14T00:23:45Z

cmd/limactl/main.go

+				if err != nil {
+					return err
+				}
+			}


What if --yes=false is explicitly specified?

Setting the value of --yes=false will not induce any effects and it will be neglected. we can just give a warning to user to prevent confusion.

docs/deprecated.md

AkihiroSuda · 2025-03-19T07:38:04Z

cmd/limactl/main.go

@@ -68,6 +68,7 @@ func newApp() *cobra.Command {
 	rootCmd.PersistentFlags().Bool("debug", false, "debug mode")
 	// TODO: "survey" does not support using cygwin terminal on windows yet
 	rootCmd.PersistentFlags().Bool("tty", isatty.IsTerminal(os.Stdout.Fd()), "Enable TUI interactions such as opening an editor. Defaults to true when stdout is a terminal. Set to false for automation.")
+	rootCmd.PersistentFlags().BoolP("yes", "y", isatty.IsTerminal(os.Stdout.Fd()), "Alias of --tty=false")


The default value seems conflicting with tty

The default value of the yes flag is changed to false which should behave as expected now.

Signed-off-by: Surya Prakash <[email protected]> - created a new boolean flag `--yes' Signed-off-by: Surya Prakash <[email protected]> fix: required changes Signed-off-by: Surya Prakash <[email protected]> - added intutive help message for the `--yes' flag - added a check with `cmd.Flags().Changed()` - changed the variable name from `ttyValue` to `yesValue` for better understanding feat: added a check usage of --yes && --tty Signed-off-by: Surya Prakash <[email protected]> fix: removed space from deprecated.md Fix: default value of the flag

AkihiroSuda

Thanks

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lima-vm/lima](https://github.com/lima-vm/lima) | minor | `v1.0.7` -> `v1.1.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lima-vm/lima (lima-vm/lima)</summary> ### [`v1.1.1`](https://github.com/lima-vm/lima/releases/tag/v1.1.1) [Compare Source](lima-vm/lima@v1.1.0...v1.1.1) #### Changes - Fixed the guestagent path issues with Homebrew ([#3566](lima-vm/lima#3566), thanks to [@jandubois](https://github.com/jandubois)) - Documentation for disk management https://lima-vm.io/docs/config/disk/ ([#3539](lima-vm/lima#3539), thanks to [@Sonichigo](https://github.com/Sonichigo)) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/15178234655 The sha256sum of the SHA256SUMS file itself is `0d2d3fb073c8e26df163937dd605e9f2b9f227814a697411cc2b8879347bdd7f` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) ### [`v1.1.0`](https://github.com/lima-vm/lima/releases/tag/v1.1.0) [Compare Source](lima-vm/lima@v1.0.7...v1.1.0) > \[!IMPORTANT] > Package maintainers should refer to "Hint for package maintainers" below Highlights: - Simplification of YAMLs - New port forwarder implementation by default - DragonflyBSD hosts - S390X and PPC64LE guests - Smaller binary packages #### Changes - Build system: - Split `lima-additional-guestagents-*.tar.gz` from `lima-*.tar.gz` ([#3503](lima-vm/lima#3503)) - Set `CONFIG_GUESTAGENT_COMPRESS=y` by default ([#3529](lima-vm/lima#3529)) - YAML: - Support inheritance ([#3072](lima-vm/lima#3072), thanks to [@jandubois](https://github.com/jandubois)) - Deprecate provision mode `ansible` ([#3451](lima-vm/lima#3451), thanks to [@afbjorklund](https://github.com/afbjorklund)) - Add new provision mode `data` ([#3302](lima-vm/lima#3302), thanks to [@jandubois](https://github.com/jandubois)) - QEMU: - Support DragonflyBSD hosts ([#3356](lima-vm/lima#3356), thanks to [@tuxillo](https://github.com/tuxillo)) - Support S390X guests ([#3319](lima-vm/lima#3319)) - Support PPC64LE guests ([#3488](lima-vm/lima#3488)) - TCG: change the default CPU from `qemu64` (x86-64 v1) to `max` ([#3487](lima-vm/lima#3487)) - Bump up the minimum QEMU version to v8.2.1 on ARM Mac. On Linux/x86\_64, QEMU v6.2.0 is still supported. ([#3491](lima-vm/lima#3491)) - WSL2: - Lots of improvements (several MRs, thanks to [@arixmkii](https://github.com/arixmkii)) - Port forwarding: - Enable faster gRPC implementation by default ([#3046](lima-vm/lima#3046)) - `limactl` CLI: - Add `--yes` flag as an alias of `--tty=false` ([#3342](lima-vm/lima#3342), thanks to [@suryaaprakassh](https://github.com/suryaaprakassh)) - Support resizing disk in `limactl edit` ([#3437](lima-vm/lima#3437), [#3533](lima-vm/lima#3533), thanks to [@songponssw](https://github.com/songponssw)) - Add `limactl disk import` command ([#3439](lima-vm/lima#3439), thanks to [@songponssw](https://github.com/songponssw)) - Rootless Containers: - Allow UID >= 524288 ([#3435](lima-vm/lima#3435)) - nerdctl: - Update from v2.0.4 to [v2.1.2](https://github.com/containerd/nerdctl/releases/tag/v2.1.2). ([#3483](lima-vm/lima#3483), [#3534](lima-vm/lima#3534), [#3560](lima-vm/lima#3560)) See also the release notes of [v2.0.5](https://github.com/containerd/nerdctl/releases/tag/v2.0.5), [v2.1.0](https://github.com/containerd/nerdctl/releases/tag/v2.1.0), [v2.1.1](https://github.com/containerd/nerdctl/releases/tag/v2.1.1). - nerdctl v2.1.1 included in Lima v1.1.0-rc.0 had a vulnerability of containerd CVE-2025-47290 (GHSA-cm76-qm8v-3j95). Other versions of Lima are not affected. - Templates: - `ubuntu-25.04`: New template ([#3445](lima-vm/lima#3445)). The `default` template still refers to Ubuntu 24.10, as `ubuntu-25.04` needs the very recent release of macOS on Intel Mac by default (see the note below). - `fedora-42`: New template ([#3434](lima-vm/lima#3434)) - `linuxbrew`: New template ([#3454](lima-vm/lima#3454)) - `almalinux-kitten-10`: New template ([#3084](lima-vm/lima#3084), thanks to [@afbjorklund](https://github.com/afbjorklund)) - `oraclelinux-8`: Fix virtiofs support ([#3441](lima-vm/lima#3441)) > \[!NOTE] > On Intel Mac with `--vm-type=vz`, macOS 15.5 or later is needed to boot `ubuntu-25.04` and `fedora-42` Full changes: https://github.com/lima-vm/lima/milestone/26?closed=1 Thanks to [@KGB33](https://github.com/KGB33) [@Nino-K](https://github.com/Nino-K) [@afbjorklund](https://github.com/afbjorklund) [@alexandear](https://github.com/alexandear) [@apachex692](https://github.com/apachex692) [@arixmkii](https://github.com/arixmkii) [@cakemanny](https://github.com/cakemanny) [@jandubois](https://github.com/jandubois) [@jonas-peter](https://github.com/jonas-peter) [@kairveeehh](https://github.com/kairveeehh) [@liangyuanpeng](https://github.com/liangyuanpeng) [@nirs](https://github.com/nirs) [@shenki](https://github.com/shenki) [@songponssw](https://github.com/songponssw) [@unsuman](https://github.com/unsuman) [@ycdzj](https://github.com/ycdzj) #### Hint for package maintainers Starting with v1.1, the official binary packages of Lima are split to two files for the each of the host OS and the architectures to save the disk space: 1. `lima-<VERSION>-Darwin-arm64.tar.gz`: (Built with `make native`) - The core components (`bin/lima`, `bin/limactl`, `share/lima/templates`, ...) - The guest agent for the native architecture (`share/lima/lima-guestagent.Linux-aarch64.gz`) 2. `lima-additional-guestagents-<VERSION>-Darwin-arm64.tar.gz`: (Built with `make additional-guestagents`) - The guest agents for emulating non-native architectures (`share/lima/lima-guestagent.Linux-{armv7l,ppc64le,riscv64,s390x,x86_64}.gz)`) For compatibility reason, `make` still builds the guest agents for all the architectures by default. Package maintainers are suggested to split their `lima` package to `lima` (`make native`) and `lima-additional-guestagents` (`make additional-guestagents`). #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/15154830653 The sha256sum of the SHA256SUMS file itself is `4391505a7f833c8245497b29fec65743abb1561a275037f6d268026284883c8a` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

AkihiroSuda reviewed Mar 12, 2025

View reviewed changes

cmd/limactl/main.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 12, 2025

View reviewed changes

cmd/limactl/main.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 12, 2025

View reviewed changes

cmd/limactl/main.go Outdated Show resolved Hide resolved

AkihiroSuda reviewed Mar 12, 2025

View reviewed changes

cmd/limactl/main.go Show resolved Hide resolved

jandubois reviewed Mar 12, 2025

View reviewed changes

suryaaprakassh force-pushed the flagFix branch from 7d70296 to 379135b Compare March 13, 2025 03:16

AkihiroSuda mentioned this pull request Mar 14, 2025

added --yes flag to edit #3350

Closed

AkihiroSuda reviewed Mar 14, 2025

View reviewed changes

docs/deprecated.md Outdated Show resolved Hide resolved

AkihiroSuda added this to the v1.1.0 milestone Mar 14, 2025

suryaaprakassh force-pushed the flagFix branch from 379135b to a39c9ab Compare March 14, 2025 04:33

AkihiroSuda requested a review from afbjorklund March 18, 2025 07:54

AkihiroSuda reviewed Mar 19, 2025

View reviewed changes

suryaaprakassh force-pushed the flagFix branch from a39c9ab to 1db3315 Compare March 26, 2025 14:02

AkihiroSuda approved these changes Mar 27, 2025

View reviewed changes

AkihiroSuda merged commit 377c1f7 into lima-vm:master Mar 27, 2025
31 checks passed

AkihiroSuda linked an issue Mar 28, 2025 that may be closed by this pull request

Add --yes flag to all subcommands that have an interactive prompt #3345

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: added a default `--yes` flag to set the tty #3342

feat: added a default `--yes` flag to set the tty #3342

Uh oh!

suryaaprakassh commented Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jandubois left a comment

Uh oh!

AkihiroSuda commented Mar 12, 2025

Uh oh!

suryaaprakassh commented Mar 13, 2025 •

edited

Loading

Uh oh!

AkihiroSuda Mar 14, 2025

Uh oh!

suryaaprakassh Mar 14, 2025

Uh oh!

Uh oh!

AkihiroSuda Mar 19, 2025

Uh oh!

suryaaprakassh Mar 26, 2025

Uh oh!

AkihiroSuda left a comment

Uh oh!

Uh oh!

Uh oh!

feat: added a default --yes flag to set the tty #3342

feat: added a default --yes flag to set the tty #3342

Uh oh!

Conversation

suryaaprakassh commented Mar 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jandubois left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Mar 12, 2025

Uh oh!

suryaaprakassh commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

suryaaprakassh Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AkihiroSuda Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

suryaaprakassh Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: added a default `--yes` flag to set the tty #3342

feat: added a default `--yes` flag to set the tty #3342

suryaaprakassh commented Mar 13, 2025 •

edited

Loading