Allow drivers to negotiate transport independent of hostagent #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hostagent will agree to whatever driver returns as a transport via BaseDriver interface. Signed-off-by: Arthur Sengileyev <[email protected]>
|
@balajiv113 could you take a look at this? I believe it really close to what you expected as the desired implementation. |
|
The current implementation is not much different from the original, but the idea is that later, with the drivers as plugins, they would be able to have their own config mechanisms, which will not be limayaml based and the transport type selection could be added at that later point w/o adding user facing complexity in limayaml. |
balajiv113
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3177
Closes #3387
Hostagent will agree to whatever driver returns as a transport via BaseDriver interface.
This is re-implemented concept from previous one. Now it follows the maintainer recommendation in #3387 (comment)
The change required was to move the configuration code from hostagent into drivers themselves to populate and then make hostagent the settings consumer.