Change limactl list --format json not to include empty objects
#4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
list-json
branch
5 times, most recently
from
b392b94 to
a1f452d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
afbjorklund
reviewed
Sep 12, 2025
afbjorklund
dismissed
their stale review
Still works for users like lima-gui, so invalid
The change to show pretty-printed JSON for TTY output only was already in #3998. This PR is only removing empty objects from the JSON output to make it identical to the YAML output. The good thing is we have tests now to make sure the output stays in JSON Lines format when written to a pipe or file. |
AkihiroSuda
reviewed
Sep 17, 2025
Unlike the YAML encoder, the JSON encoder will encode empty structs
even when they have the `json:",omitempty"` tag (it will only emit nil
pointers to structs).
This commit repeatedly removes empty objects until the result no
longer gets any shorter. It doesn't check for the omitempty tag, but
we have that tag set on every struct.
Example: this removes `"vmOpts":{"qemu":{},"vz":{"rosetta":{}}}`.
Signed-off-by: Jan Dubois <[email protected]>
Always put --format at the end of the command to make it easier to spot the difference between the commands. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
list-json
branch
from
a1f452d to
7a7795a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the YAML encoder, the JSON encoder will encode empty structs even when they have the
json:",omitempty"tag (it will only emit nil pointers to structs).This commit repeatedly removes empty objects until the result no longer gets any shorter. It doesn't check for the omitempty tag, but we have that tag set on every struct.
Example: this removes
"vmOpts":{"qemu":{},"vz":{"rosetta":{}}}.