fix(shell-sync): show both rsync & diff stats for View the changed contents#4696
Merged
AkihiroSuda merged 1 commit intolima-vm:masterfrom Mar 12, 2026
Merged
Conversation
jandubois
previously approved these changes
Mar 9, 2026
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Thanks, LGTM, but I have some nit-picking comments you might want to look at
unsuman
force-pushed
the
fix/show-shell-sync-0byte-newfile
branch
from
efd8b6b to
c03d4f8
Compare
jandubois
previously approved these changes
Mar 11, 2026
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Sorry, but I really only want to see "No changes", without the whole rsync dry-run and empty diff output.
I thought the command should provide feedback to the user, but I think it should still be special cased to not show
--- rsync dry-run statistics ---
No changes
--- detailed diff ---
Otherwise the PR is fine, but I would prefer this to still look a little nicer.
Member
Author
|
I think if there are no changes, it's better not show the interactive prompt at all. |
unsuman
force-pushed
the
fix/show-shell-sync-0byte-newfile
branch
from
c03d4f8 to
853a24c
Compare
Member
Author
|
Also made the headers grey |
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
unsuman
force-pushed
the
fix/show-shell-sync-0byte-newfile
branch
from
853a24c to
3674e55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4693
Using
diff -ruNfails to report newly added empty files when comparing directories. A workaround here is to show both the rsync dry-run stats and the diff output: