[DO NOT MERGE] [FOR 2.2.0 or Later] Set minimal QEMU version to 11.0.0 on Windows#4970
Draft
arixmkii wants to merge 2 commits into
Draft
[DO NOT MERGE] [FOR 2.2.0 or Later] Set minimal QEMU version to 11.0.0 on Windows#4970arixmkii wants to merge 2 commits into
arixmkii wants to merge 2 commits into
Conversation
This was implemented to support QEMU version before 11.0.0, but since there is no LTS releases for QEMU on Windows the minimal version is bumped to the one not needing special handling. Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
Signed-off-by: Arthur Sengileyev <arthur.sengileyev@gmail.com>
Contributor
Author
|
I messed up lints, but it is ok for now because Windows tests are actually fine. I will factor out unpinning from this PR and re-submit and will rebase and force push the changes, when 2.2.0 merge window opens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for
2.2.0or later. I need to try it once in the CI to see the reproducer for the root cause of the QEMU pining, because I tried it locally and in a third party GH repo with GHA and can't get the test failure. If CI fails I will try to investigate further w/o hogging CI for the project and postpone patch waiting for later QEMU if needed. There should be a QEMU point release in 2 weeks https://lists.nongnu.org/archive/html/qemu-devel/2026-05/msg02947.html, so, it might bring some fixes as well, but it is a bit iffy when/if the release will be built for Windows and when/ifwingetwill update the repo.Potentially fixes #4949