feat:add virtio-sound interface#5016
Open
Aneesh-Hegde wants to merge 1 commit into
Open
Conversation
Aneesh-Hegde
force-pushed
the
add-audio
branch
2 times, most recently
from
1ca8b0e to
513b535
Compare
Signed-off-by: Aneesh-Hegde <aneeshhegde7110@gmail.com>
Contributor
Author
|
Hey @jandubois can you PTAL whenever you have time. Thanks:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3730
Local Test result:
OS: Arch Linux
$ ./_output/bin/limactl start --name=test-virtio --audio-interface=virtio --audio-device=none template:default $ ./_output/bin/limactl shell test-virtio sudo lspci | grep -i audio 00:05.0 Multimedia audio controller: Red Hat, Inc. Virtio 1.0 sound (rev 01)$ ./_output/bin/limactl start --name=test-hda --audio-interface=hda template:default $ ./_output/bin/limactl shell test-hda sudo lspci | grep -i audio 00:05.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio Controller (rev 03)Note on Cross-Platform Testing (macOS & Windows):
Due to host OS limitations, I am unable to test the macOS and Windows specific drivers locally.