Change %q in logs and errors to %#q [Part2]#5017
Open
mie313 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Lints tests failed, but I am not sure how to resolve it because:
I would be grateful if you could let me know how to address them (if I should change something). |
Member
|
Please rebase on latest |
Contributor
Author
|
Thank you for your advice. |
jandubois
reviewed
May 21, 2026
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Looks good, but has a few minor issues.
| pidFile := filepath.Join(inst.Dir, filenames.PIDFile(*inst.Config.VMType)) | ||
| if _, err := os.Stat(pidFile); !errors.Is(err, os.ErrNotExist) { | ||
| logrus.Errorf("pidfile %q already exists", pidFile) | ||
| logrus.Errorf("pidfile %#qq already exists", pidFile) |
Member
There was a problem hiding this comment.
Suggested change
| logrus.Errorf("pidfile %#qq already exists", pidFile) | |
| logrus.Errorf("pidfile %#q already exists", pidFile) |
|
|
||
| func (l *LimaVzDriver) Start(ctx context.Context) (chan error, error) { | ||
| logrus.Infof("Starting VZ (hint: to watch the boot progress, see %q)", filepath.Join(l.Instance.Dir, "serial*.log")) | ||
| logrus.Infof("Starting VZ (hint: to watch the boot progress, see %#qq)", filepath.Join(l.Instance.Dir, "serial*.log")) |
Member
There was a problem hiding this comment.
Suggested change
| logrus.Infof("Starting VZ (hint: to watch the boot progress, see %#qq)", filepath.Join(l.Instance.Dir, "serial*.log")) | |
| logrus.Infof("Starting VZ (hint: to watch the boot progress, see %#q)", filepath.Join(l.Instance.Dir, "serial*.log")) |
| } | ||
| if !strings.Contains(string(out), "com.apple.security.hypervisor") { | ||
| return fmt.Errorf("binary %q seems signed but lacking the \"com.apple.security.hypervisor\" entitlement", qExe) | ||
| return fmt.Errorf("binary %#q seems signed but lacking the \"com.apple.security.hypervisor\" entitlement", qExe) |
Member
There was a problem hiding this comment.
Should we use backticks everywhere?
Suggested change
| return fmt.Errorf("binary %#q seems signed but lacking the \"com.apple.security.hypervisor\" entitlement", qExe) | |
| return fmt.Errorf("binary %#q seems signed but lacking the `com.apple.security.hypervisor` entitlement", qExe) |
There are more instances of \" around; I can't remember, but though we changed all of them.
Signed-off-by: mie313 <mie313.tanaka@gmail.com>
Contributor
Author
|
Thank you for your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change %q in logs and errors to %#q (all files in the following directories) .
cmd/lima-guestagentpkg/apfspkg/autostartpkg/cacheutilpkg/cidatapkg/copytoolpkg/downloaderpkg/driverpkg/driverutilpkg/editutilpkg/envutilpkg/fileutilspkg/limayamlRelated issue: #4898
This PR is a continuation of the work from #4909 .
@jandubois
I also addressed your last comments in #4909 in this PR.