Adding configs for retries, retrywait, timeout, and chunksize#41
Merged
Adding configs for retries, retrywait, timeout, and chunksize#41
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 28.15% 28.15%
=======================================
Files 14 14
Lines 341 341
=======================================
Hits 96 96
Misses 245 245 ☔ View full report in Codecov by Sentry. |
drewoldag
reviewed
Aug 23, 2024
drewoldag
approved these changes
Aug 23, 2024
Collaborator
drewoldag
left a comment
drewoldag
left a comment
There was a problem hiding this comment.
Looks fine to me. One small question, not a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty straightforward addition of these configs with documentation.