Skip to content

First implementation with pytorch ignite to support cpu->multi-gpu scaling#54

Merged
drewoldag merged 11 commits intomainfrom
issue/47/multi-gpu-support
Sep 18, 2024
Merged

First implementation with pytorch ignite to support cpu->multi-gpu scaling#54
drewoldag merged 11 commits intomainfrom
issue/47/multi-gpu-support

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

@drewoldag drewoldag commented Aug 28, 2024

First attempt at using pytorch ignite to support the promise of scaling from cpu->gpu->multi-gpu.

@drewoldag drewoldag self-assigned this Aug 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 4.91803% with 58 lines in your changes missing coverage. Please review.

Project coverage is 38.33%. Comparing base (3ee8380) to head (706a355).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/train.py 0.00% 40 Missing ⚠️
src/fibad/models/example_autoencoder.py 10.00% 9 Missing ⚠️
src/fibad/models/example_cnn_classifier.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   38.90%   38.33%   -0.58%     
==========================================
  Files          17       17              
  Lines         712      720       +8     
==========================================
- Hits          277      276       -1     
- Misses        435      444       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2024

Before [3ee8380] After [fa2b105] Ratio Benchmark (Parameter)
1.62±0.8s 1.74±2s 1.07 benchmarks.time_computation
3.5k 2.69k 0.77 benchmarks.mem_list

Click here to view all benchmarks.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drewoldag drewoldag requested a review from mtauraso September 13, 2024 22:45
@drewoldag drewoldag changed the title WIP - Experimenting with pytorch ignite support for DistributedDataParallel First implementation with pytorch ignite to support cpu->multi-gpu scaling Sep 13, 2024
@drewoldag drewoldag marked this pull request as ready for review September 13, 2024 22:47
@drewoldag drewoldag merged commit 2fb3a74 into main Sep 18, 2024
@drewoldag drewoldag deleted the issue/47/multi-gpu-support branch September 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-gpu instance on slurm produces error - investigate use of DistributedDataParallel

2 participants