Skip to content

Updating docstrings so that sphinx will build the documentation.#581

Merged
drewoldag merged 8 commits intomainfrom
awo/fix-local-doc-builds
Jan 7, 2026
Merged

Updating docstrings so that sphinx will build the documentation.#581
drewoldag merged 8 commits intomainfrom
awo/fix-local-doc-builds

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

Small edits to docstrings:

  • whitespace
  • type hints

Autoapi was trying and failing to import _version.py. I was unable to instruct it to ignore that file, so instead I have suppressed that warning. Which may or may not be a great thing.

@drewoldag drewoldag self-assigned this Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 22:42
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@drewoldag drewoldag requested review from a team, gitosaurus, maxwest-uw and mtauraso and removed request for a team January 6, 2026 22:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates docstrings to improve Sphinx documentation generation. The changes focus on correcting type hints and formatting docstrings to comply with Sphinx/NumPy documentation standards.

  • Updates type hints in docstrings to use more precise Python module references (e.g., pathlib.Path, collections.abc.Callable)
  • Improves docstring formatting with proper section headers (Note, Examples) and indentation for nested lists
  • Suppresses autoapi import warnings in Sphinx configuration and removes -W (warnings-as-errors) flag from pre-commit hooks to allow documentation to build despite import issues with _version.py

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/hyrax/pytorch_ignite.py Updated type hints in docstrings to use full module paths for dataset and Engine types
src/hyrax/plugin_utils.py Updated type hints from generic "function" and "str" to more precise collections.abc.Callable and pathlib.Path
src/hyrax/model_exporters.py Updated type hints from "NumPy array" and "Path" to np.ndarray and pathlib.Path
src/hyrax/data_sets/random/hyrax_random_dataset.py Fixed indentation and formatting for nested list items in docstrings
src/hyrax/data_sets/hyrax_csv_dataset.py Improved documentation structure with proper Note and Examples sections using reST formatting
docs/pre_executed/hyraxql_iterable_demo.ipynb Removed notebook file (no longer needed or referenced in docs)
docs/conf.py Added suppression of autoapi import resolution warnings
.pre-commit-config.yaml Removed -W flag to allow docs to build with warnings instead of treating them as errors

validation_data_loader : DataLoader
The data loader for the validation data
trainer : Engine
trainer : pytorch-ignite.Engine
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint format "pytorch-ignite.Engine" is non-standard and may not be recognized by Sphinx or static type checkers. It should be "ignite.engine.Engine" or just "Engine" (since Engine is already imported from ignite.engine at the top of the file).

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.28%. Comparing base (bda3e28) to head (d4236ad).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   55.28%   55.28%           
=======================================
  Files          53       53           
  Lines        5256     5256           
=======================================
  Hits         2906     2906           
  Misses       2350     2350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@mtauraso mtauraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit we probably want to turn back on "-W" since it protects us from broken internal links.

Otherwise this looks reasonable.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2026

Before [bda3e28] <v0.6.9> After [678ab9e] Ratio Benchmark (Parameter)
1.68±0.01s 1.82±0.04s 1.08 benchmarks.time_train_help
1.68±0.03s 1.74±0.03s 1.04 benchmarks.time_umap_help
1.68±0.05s 1.73±0.04s 1.03 benchmarks.time_lookup_help
1.70±0.05s 1.75±0.04s 1.03 benchmarks.time_prepare_help
1.70±0.02s 1.74±0.02s 1.03 benchmarks.time_visualize_help
507±10ms 523±8ms 1.03 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(256, 'chromadb')
8.36±0.1ms 8.63±0.3ms 1.03 vector_db_benchmarks.VectorDBSearchBenchmarks.time_search_by_vector_many_shards(128, 'chromadb')
1.70±0.06s 1.72±0.06s 1.02 benchmarks.time_infer_help
32.0±0.07ms 32.5±0.2ms 1.02 benchmarks.time_nb_obj_construct
1.69±0.05s 1.72±0.05s 1.02 benchmarks.time_rebuild_manifest_help

Click here to view all benchmarks.

Add command to prune UV cache before installing dependencies.
@drewoldag drewoldag merged commit 3d0f42e into main Jan 7, 2026
10 checks passed
@drewoldag drewoldag deleted the awo/fix-local-doc-builds branch January 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants