Scaffolding for config file handling and model selection#6
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
mtauraso
approved these changes
Aug 12, 2024
Collaborator
mtauraso
left a comment
There was a problem hiding this comment.
LGTM. Good to add tests, but I'm in favor of this getting merged even as-is.
This was
linked to
issues
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents the scaffolding work for two aspects of fibad:
To use a built in model from the registry a user specifies in the .toml config file the following:
To specify a model outside of fibad, the users .toml config would include something like the following example. Basically what the user would write in a
from ... import ...statement.Included here is an implementation of PyTorch's "Getting Started" CNN for classifying images in the CIFAR10 dataset - note that this is incomplete, and meant to be a way to test the model registration process, and will be a testbed for future work.