Conversation
| include_benchmarks: true | ||
| include_docs: true | ||
| include_notebooks: true | ||
| mypy_type_checking: none |
There was a problem hiding this comment.
We have a lot of type annotations. Do we want to turn type checking on as a way to keep that habit?
(I ask not knowing if this does what I think it does or not 😄 )
There was a problem hiding this comment.
Hmm, it could be a beneficial thing to do so. It will slow down committing code, but the value add might be appreciated by the end users. I'll create an issue for it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 35.55% 35.55%
=======================================
Files 18 18
Lines 869 869
=======================================
Hits 309 309
Misses 560 560 ☔ View full report in Codecov by Sentry. |
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
I'm sad because I think I know why this line has been added, and I think it is a bug in my recently-merged PPT change.
No description provided.