Skip to content

Basic CitationCompass integration#793

Draft
mtauraso wants to merge 8 commits intomainfrom
codex/plan-minimal-integration-with-hyrax
Draft

Basic CitationCompass integration#793
mtauraso wants to merge 8 commits intomainfrom
codex/plan-minimal-integration-with-hyrax

Conversation

@mtauraso
Copy link
Copy Markdown
Collaborator

Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.


Codex Task

Copilot AI review requested due to automatic review settings March 17, 2026 18:35
@mtauraso mtauraso marked this pull request as draft March 17, 2026 18:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class citation metadata for Hyrax and a curated dependency-citation workflow via Citation Compass, with lightweight validation and user-facing documentation.

Changes:

  • Add CITATION.cff for citing Hyrax itself.
  • Add citation_compass.toml to curate “methodologically central” dependency citations and document the canonical generation command.
  • Add tests and docs updates to ensure citation artifacts remain present and discoverable.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/hyrax/test_citation_metadata.py Adds basic tests to assert citation files exist and contain expected content.
README.md Documents how to cite Hyrax and how to generate dependency citations.
docs/reference_and_faq.rst Adds a reference/FAQ section describing citation and attribution workflows.
CITATION.cff Introduces repository-root citation metadata for Hyrax.
citation_compass.toml Adds curated Citation Compass configuration for key dependencies.
CITATION_COMPASS_IMPLEMENTATION_PLAN.md Adds a short implementation plan and maintenance policy for the citation workflow.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026

Before [6148393] After [a06c126] Ratio Benchmark (Parameter)
1.97±0.03s 2.06±0.03s 1.05 benchmarks.time_database_connection_help
296±3ms 310±5ms 1.05 benchmarks.time_import
15.465946515928916 16.203467288067017 1.05 data_cache_benchmarks.DataCacheBenchmarks.track_cache_hsc1k_hyrax_size_undercount
2.02±0.02s 2.09±0.03s 1.03 benchmarks.time_help
2.04±0.01s 2.11±0.04s 1.03 benchmarks.time_infer_help
1.47G 1.52G 1.03 vector_db_benchmarks.VectorDBInsertBenchmarks.peakmem_load_vector_db(16384, 'chromadb')
1.98±0.04s 2.03±0.02s 1.02 benchmarks.time_lookup_help
40.2±0.5ms 40.9±1ms 1.02 benchmarks.time_nb_obj_dir
3.71±0.01s 3.77±0.01s 1.02 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(256, 'chromadb')
5.26±0.02s 5.37±0.04s 1.02 vector_db_benchmarks.VectorDBInsertBenchmarks.time_load_vector_db(64, 'qdrant')

Click here to view all benchmarks.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mtauraso mtauraso changed the title Codex-generated pull request Basic CitationCompass integration Mar 17, 2026
@mtauraso
Copy link
Copy Markdown
Collaborator Author

@copilot Can you resolve the pre-commit error in CI on this? It appears to be a ruff formatting thing.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 17, 2026

@mtauraso I've opened a new pull request, #794, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits March 17, 2026 15:59
* Initial plan

* Fix ruff formatting: sort imports and wrap long line in test_citation_metadata.py

Co-authored-by: mtauraso <31012+mtauraso@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mtauraso <31012+mtauraso@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.93%. Comparing base (7e4b1fa) to head (273ab83).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   64.84%   64.93%   +0.09%     
==========================================
  Files          61       61              
  Lines        5896     5912      +16     
==========================================
+ Hits         3823     3839      +16     
  Misses       2073     2073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtauraso mtauraso marked this pull request as ready for review March 18, 2026 21:32
@jeremykubica
Copy link
Copy Markdown
Contributor

I don't think the command

python -m citation_compass --config citation_compass.toml

in your PR will work. Currently citation compass doesn't have a main, so it can't be run. It also doesn't process toml files. We could add this to citation-compass if it would be useful though.

@mtauraso mtauraso marked this pull request as draft March 23, 2026 18:49
@mtauraso
Copy link
Copy Markdown
Collaborator Author

Given this feedback and a closer look at citation-compass I'm going to have a re-think about this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants