Conversation
There was a problem hiding this comment.
Pull request overview
Adds first-class citation metadata for Hyrax and a curated dependency-citation workflow via Citation Compass, with lightweight validation and user-facing documentation.
Changes:
- Add
CITATION.cfffor citing Hyrax itself. - Add
citation_compass.tomlto curate “methodologically central” dependency citations and document the canonical generation command. - Add tests and docs updates to ensure citation artifacts remain present and discoverable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/hyrax/test_citation_metadata.py | Adds basic tests to assert citation files exist and contain expected content. |
| README.md | Documents how to cite Hyrax and how to generate dependency citations. |
| docs/reference_and_faq.rst | Adds a reference/FAQ section describing citation and attribution workflows. |
| CITATION.cff | Introduces repository-root citation metadata for Hyrax. |
| citation_compass.toml | Adds curated Citation Compass configuration for key dependencies. |
| CITATION_COMPASS_IMPLEMENTATION_PLAN.md | Adds a short implementation plan and maintenance policy for the citation workflow. |
You can also share your feedback on Copilot code review. Take the survey.
Click here to view all benchmarks. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot Can you resolve the pre-commit error in CI on this? It appears to be a ruff formatting thing. |
* Initial plan * Fix ruff formatting: sort imports and wrap long line in test_citation_metadata.py Co-authored-by: mtauraso <31012+mtauraso@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mtauraso <31012+mtauraso@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 64.84% 64.93% +0.09%
==========================================
Files 61 61
Lines 5896 5912 +16
==========================================
+ Hits 3823 3839 +16
Misses 2073 2073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think the command in your PR will work. Currently citation compass doesn't have a main, so it can't be run. It also doesn't process toml files. We could add this to citation-compass if it would be useful though. |
|
Given this feedback and a closer look at citation-compass I'm going to have a re-think about this PR. |
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task