Skip to content

Reduce pr template size#85

Merged
drewoldag merged 6 commits intomainfrom
awo/reduce-pr-template-size
Oct 8, 2024
Merged

Reduce pr template size#85
drewoldag merged 6 commits intomainfrom
awo/reduce-pr-template-size

Conversation

@drewoldag
Copy link
Copy Markdown
Collaborator

I'm going out on a limb and reducing the number of checkboxes that I have to click in the PR template by a lot. Please feel free to push back if they are useful for you!

aritraghsh09 and others added 6 commits October 2, 2024 14:02
* Contains a simple introduction with installation instructions and misc information
* Added comment about similarity-search
* Added a few badges
Changing a section name
@drewoldag drewoldag self-assigned this Oct 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2024

Before [8ca2e8f] After [86b2203] Ratio Benchmark (Parameter)
3.01±1s 3.51±0.6s ~1.17 benchmarks.time_computation
3.96k 168 0.04 benchmarks.mem_list

Click here to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.55%. Comparing base (8ca2e8f) to head (0c3e3cb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   35.55%   35.55%           
=======================================
  Files          18       18           
  Lines         869      869           
=======================================
  Hits          309      309           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@aritraghsh09 aritraghsh09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Copy Markdown
Collaborator

@mtauraso mtauraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@drewoldag drewoldag merged commit 6207ebc into main Oct 8, 2024
@drewoldag drewoldag deleted the awo/reduce-pr-template-size branch October 8, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants