Skip to content

Fixing issue with ConfigDict.#87

Merged
mtauraso merged 1 commit intomainfrom
issue/86/fixup
Oct 8, 2024
Merged

Fixing issue with ConfigDict.#87
mtauraso merged 1 commit intomainfrom
issue/86/fixup

Conversation

@mtauraso
Copy link
Copy Markdown
Collaborator

@mtauraso mtauraso commented Oct 8, 2024

This should make fibad train work out of the box

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2024

Before [6207ebc] After [59ee973] Ratio Benchmark (Parameter)
1.46±0.7s 2.18±1s ~1.50 benchmarks.time_computation
656 2.66k 4.06 benchmarks.mem_list

Click here to view all benchmarks.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.55%. Comparing base (6207ebc) to head (46376d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   35.55%   35.55%           
=======================================
  Files          18       18           
  Lines         869      869           
=======================================
  Hits          309      309           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also switching default data loader to CifarDataSet so 'fibad train' works out of the box
@mtauraso mtauraso requested a review from drewoldag October 8, 2024 18:38
@mtauraso mtauraso linked an issue Oct 8, 2024 that may be closed by this pull request
@mtauraso mtauraso merged commit 3068b8f into main Oct 8, 2024
@mtauraso mtauraso deleted the issue/86/fixup branch October 8, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling fibad train from the command line produces error

2 participants