Remove unexpected_cfgs from the lint set
#117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fully backwards-compatible change, because `unexpected_cfgs` is already warn by default Going through the history, this was added to the lint set because: - Xilem set the lint explicitly to support the cfgs it needed (FALSE and tarpaulin) - linebender/peniko#47 copied the lints from Xilem, even though it didn't need to configure unexpected_cfgs - The original lint set PR was based on the set in Peniko I've treated this as v6.1 due to the backwards compatibility.
waywardmonkeys
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fully backwards-compatible change, because
unexpected_cfgsis already warn by defaultGoing through the history, this was added to the lint set because:
I've treated this as v6.1 due to the backwards compatibility. We can make the next change be v7.0 or just v7 again.