Skip to content

Remove unexpected_cfgs from the lint set #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Jun 27, 2025

This is a fully backwards-compatible change, because unexpected_cfgs is already warn by default

Going through the history, this was added to the lint set because:

  • Xilem set the lint explicitly to support the cfgs it needed (FALSE and tarpaulin)
  • Import the Linebender lint set. MSRV -> 1.74 peniko#47 copied the lints from Xilem, even though it didn't need to configure unexpected_cfgs
  • The original lint set PR was based on the set in Peniko

I've treated this as v6.1 due to the backwards compatibility. We can make the next change be v7.0 or just v7 again.

This is a fully backwards-compatible change, because
`unexpected_cfgs` is already warn by default

Going through the history, this was added to the lint set because:
- Xilem set the lint explicitly to support the cfgs it needed (FALSE and tarpaulin)
- linebender/peniko#47 copied the lints from Xilem, even though it didn't need to configure unexpected_cfgs
- The original lint set PR was based on the set in Peniko

I've treated this as v6.1 due to the backwards compatibility.
@DJMcNab DJMcNab merged commit beec196 into linebender:main Jun 27, 2025
2 checks passed
@DJMcNab DJMcNab deleted the unexpected-unexpected-cfg branch June 27, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants