withI18n does not copy over static methods

[elios264]

As stated in React docs when creating a HOC, you need to copy over the static methods,

Some of my components declare static properties, but they are undefined when using withI18n

This fix is simple, the only addition is to call hoistNonReactStatic over the hoisted and original component

[tricoder42]

Do you think this should be baked to jsLingui or simply adding a note to documentation is enough?

import hoistNonReactStatic from 'hoist-non-react-statics';

class Page extends React.Component { ... }

export default hoistNonReactStatic(withI18n()(Page), Page)

I'm not sure if we should do it implicitly. Larger bundle is just one disadvantage, even though the package seems to be rather small.

[vonovak]

I think it is good practice to hoist the statics. I think you may also use render prop instead of a HOC and they don't need hoisting afaik.

[elios264]

I would add it to jsLingui, because "strictly" speaking any HOC should add additional functionality without removing other and withI18n is removing that feature, react-redux which also provides the connect HOC is also hoisting the static methods and props.

But in any case this can easly be done outside like you stated:
export default hoistNonReactStatic(withI18n()(Page), Page)

And since it is your package the decision is up to you.

[tricoder42]

Make sense, I'll add it to keep HOC behavior consistent.

[tricoder42]

Fixed in latest release v2.3.0.