fix(webpack + vite): fix dependency watching in loader#1662
Merged
andrii-bodnar merged 2 commits intoMay 17, 2023
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
andrii-bodnar
approved these changes
May 17, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
+ Coverage 75.48% 75.56% +0.08%
==========================================
Files 79 79
Lines 2011 2018 +7
Branches 518 519 +1
==========================================
+ Hits 1518 1525 +7
Misses 379 379
Partials 114 114
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug introduced in #1654
Closes: #1661
Vite's
addWatchFiledoes not have a file existance check as webpack has, so i have to add check it manually before.Also, we need an e2e tests for /example projects. Because this kind of things really hard to test from build side.