feat(webpack + vite): Ensure that bundlers respect catalog dependencies#1654
Merged
andrii-bodnar merged 1 commit intoMay 16, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrii-bodnar
approved these changes
May 16, 2023
Contributor
andrii-bodnar
left a comment
There was a problem hiding this comment.
@thekip thank you! Please rebase the branch, there was an issue before in the main branch
fba79ef to
45a222d
Compare
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 75.40% 75.48% +0.08%
==========================================
Files 77 79 +2
Lines 1996 2011 +15
Branches 516 518 +2
==========================================
+ Hits 1505 1518 +13
- Misses 377 379 +2
Partials 114 114
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catalog compiler operates on a bunch of files when compiling one catalog (template + fallbacks + source language). Loaders in bundlers expecting deterministic results, meaning for the same source it should always produce the same result.
Currently, implementation of webpack loader / vite plugin does not respect catalog dependencies. That breaks caching in Webpack and watch mode (catalog will not be rebuilt if one of the dependencies changed)
This PR brings tracking of all catalog dependencies and should resolve mentioned issues.
Types of changes
Fixes # (issue)
Checklist